feat(clients): bring AEGIS Omega App Intents package under version control - #242
Open
Tarik Skalić (tarikskalic33) wants to merge 3 commits into
Open
feat(clients): bring AEGIS Omega App Intents package under version control#242Tarik Skalić (tarikskalic33) wants to merge 3 commits into
Tarik Skalić (tarikskalic33) wants to merge 3 commits into
Conversation
…ntrol The package existed only in a transient agent scratch directory (Documents\Codex\2026-07-28\...\outputs\). That is the same class of location where the holon-gram compiler was lost permanently when its container was reclaimed. Untracked agent output is one cleanup away from gone. Also makes it build off-Apple: AppIntents ships only in Apple SDKs, so the two AppIntents sources and the test exercising AEGISSessionModeIntentValue are guarded with #if canImport(AppIntents). The pure-Foundation route model and router then compile and test on Linux/Windows, keeping the routing logic verifiable without a Mac. Apple builds are unchanged. Adds three tests: route equality by payload, AEGISSessionMode raw-value round trip including rejection of an unknown value, and that clear() on a superseded handoff does not drop the current one. Router tests reset the shared singleton via defer. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
aegisomega | f05304e | Commit Preview URL Branch Preview URL |
Jul 29 2026, 07:45 PM |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Summary by QodoVendor AEGIS Omega App Intents Swift package and make core testable cross-platform
AI Description
Diagram
High-Level Assessment
Files changed (8)
|
Code Review by Qodo
Context used✅ Compliance rules (platform):
11 rules 1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2884ed4bb6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
…iscovery Three findings from review of #242: - AEGISIntentRouter.pendingHandoff is now public private(set). It was publicly writable, which let a caller bypass the id-matching guard in clear(_:) and drop a handoff that had already been superseded. - Adds AEGISOmegaAppIntentsPackage so an app target can declare this package in includedPackages. Intents defined in a package are not indexed by Siri, Spotlight, or Shortcuts without that registration. - Test methods are nonisolated and async, with the main-actor hop inside each body. SwiftPM derives its test-discovery list from unapplied method references, so @mainactor on a method changes that reference's type to (Self) -> @mainactor () -> Void. Mixed isolation failed to compile off-Apple with a conflicting-'Element' error; uniform type-level isolation compiled but then failed to cast at run time, and the runner silently executed 0 tests. Verified on Windows (Swift 6.3.3, x86_64-unknown-windows-msvc): swift test -> Executed 4 tests, with 0 failures. The fifth test is inside #if canImport(AppIntents) and is correctly excluded off-Apple. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The package existed only in a transient agent scratch directory —
Documents\Codex\2026-07-28\build-ios-apps-ios-app-intents-2\outputs\.That is the same class of location where the holon-gram compiler (8 files, +4446/−889) was lost permanently: reported complete, never pushed, container reclaimed. Verified this session — it appears in zero git objects and in zero of 492 local session transcripts as source; only the
+1599diffstat survives. Untracked agent output is one cleanup away from gone.What changed
Six source files + a README, unmodified in behaviour on Apple platforms.
Cross-platform guard.
AppIntentsships only in Apple SDKs, soswift buildfails off-Apple. The two AppIntents-dependent sources are wrapped in#if canImport(AppIntents), as is the test exercisingAEGISSessionModeIntentValue(it referenced an AppIntents-only type, so the suite wouldn't compile either). The pure-FoundationAEGISIntentRoute/AEGISIntentRouterand their tests now build and run on Linux/Windows — the routing logic stays continuously verifiable without a Mac.Three added tests:
continueContext("a")≠continueContext("b"); differingmode≠)AEGISSessionModeraw-value round trip acrossallCases, plus rejection of an unknown valueclear()on a superseded handoff must not drop the current oneOne test-isolation fix: router tests mutate the
AEGISIntentRouter.sharedsingleton and previously left it dirty; they now reset viadefer.Reviewer notes
swift buildon Windows additionally needs MSVClink.exe(VC++ workload, elevated install). Documented in the README and inCLAUDE.md§ Verified Failure Modes.origin/main; no unrelated files included.